On Wed, Mar 2, 2011 at 5:36 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
> I recall running across multiple issues though that this statement > seemed to help. I can't recall now what issue was so obviously I > should have added a comment when I noticed it. > Yeah, there was reasons for that if-statement. While I was trying to deal with the tool on tablet case, I felt it would much more clean to move the stuff to wcmUSB.c first. > I think one issue was what you mention. kernel filtering+memset() in > xf86-input-wacom resulted in high chance of X or Y being zero and so > return as work around. We are no longer memset()'ing for generic and > protocol 4 so issue is limited to protocol 5 devices. > The best way to make sure we get reliable events is to retrieve whatever missing from the kernel directly. That would need some time to work on. You can take the lead if you are interested. > Whats a little strange is above if() ignored TOUCH case but it has > exact same issue (but also now resolved). > Well, touch was first introduce in Nov. 2008, at version 2.6.28. So, I guess we didn't see any issues with touch then. > I think the other "issue" I saw was probably just an observation I > had. If we can fix the memset() issue then its a good idea to add > first 3 packets to filter window and return instead of just returning. > This would be similar to what xf86-input-synatpics does so that we > never use an un-averaged value from HW. Today, the first 3 are > un-averaged and so have sample errors. > This is a corner case. Maybe the if-statement was also a reason for that. > So at least I agree with your plan of action since it keeps moving us > forward. > The convert device_id to device_type routine (don't remember the name of the routine) should also be moved to wcmUSB.c. But it needs some plan before the move. > > Reviewed-by: Chris Bagwell <ch...@cnpbagwell.com> Thanks. Ping
------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
