Hi Chris, Now you tell me. :)
Actually I vaguely remember that patch. Appreciate it if you could refresh my memory and direct me to it. I have some probable testers, because they are complaining of stylus "jitters". Let me quote BackBONE7: > Than's for the tip! Hover works great. > The jumps seem to be independet from RawSample, Suppress and Threshold. >I even switched gestures off, and did a reset of the Tablet Area. > If there would be a filter that ignores events that are further away from the > last cursor position as, lets say 30 to 80 Pixels, that might help. I > downloaded the Source and thought maybe i can do a quick hack to test it, but > i > don't understand all of it, needles to say i'm not a good programmer. > I am sure there is a solution, i'm still frustraded thou. And we now know why RawSample wasn't doing anything. Favux On Wed, Mar 9, 2011 at 10:41 AM, Chris Bagwell <ch...@cnpbagwell.com> wrote: > On Tue, Mar 8, 2011 at 8:50 PM, Peter Hutterer <peter.hutte...@who-t.net> > wrote: >> On Tue, Mar 08, 2011 at 05:50:45PM -0800, Jason Gerecke wrote: >>> I made the mistake of setting this to zero and then bringing my >>> pen into proximity. Ooops. X crashed. Looks like mathematics >>> still can't handle getting the average of zero things ;) >>> >>> Signed-off-by: Jason Gerecke <killert...@gmail.com> >>> --- >>> src/wcmXCommand.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c >>> index 4207dbe..e589e37 100644 >>> --- a/src/wcmXCommand.c >>> +++ b/src/wcmXCommand.c >>> @@ -620,7 +620,7 @@ int wcmSetProperty(DeviceIntPtr dev, Atom property, >>> XIPropertyValuePtr prop, >>> if ((values[0] < 0) || (values[0] > 100)) >>> return BadValue; >>> >>> - if ((values[1] < 0) || (values[1] > XWACOM_MAX_SAMPLES)) >>> + if ((values[1] < 1) || (values[1] > XWACOM_MAX_SAMPLES)) >>> return BadValue; >>> >>> if (!checkonly) >>> -- >>> 1.7.1 >> >> doesn't this need the same check in wcmParseOptions? > > Yes, the whole if() should be added to new RawSample (patch 3 of 4). > >> >> also, out of interest - what does RawSample actually do? there's nothing in >> the man page. > > Perhaps we can rename the option while we are here? > > Its value is the window size on sliding window average done on > incoming raw samples with default of 4. SampleWindow or SampleCount > may be better names. > > If someone makes a man page patch, its probably worth noting that > ISDv4 do not currently do averaging. I had a patch that enables that > but needs testing by someone with said device. I'm a little confused > why ISDv4 people are not complaining about non-smooth drawing. > > Chris > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel > ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
