On Wed, Mar 9, 2011 at 9:27 AM, <ch...@cnpbagwell.com> wrote:
> From: Chris Bagwell <ch...@cnpbagwell.com>
>
> Over time, we've merged device specific filter routines
> into single version. So there is no need for historic
> hook to register at runtime.
>
> ISDv4 devices never registered any filter which seems
> like it would result in jitter.
>
> Removed RawFilter() from WacomDevice structure and call
> wcmFilterCoord() directly from wcmCommon.c.
>
> Signed-off-by: Chris Bagwell <ch...@cnpbagwell.com>
>
Reviewed-by: Ping Cheng <pingli...@gmail.com>.
Thank you Chris.
Ping
> ---
>
> Updated an older patch to work against current HEAD. Resending
> as requested by David to forward to users that are complaining
> about jitter on ISDv4 devices for further testing.
>
> src/wcmCommon.c | 5 ++---
> src/wcmUSB.c | 2 --
> src/xf86WacomDefs.h | 2 --
> 3 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/src/wcmCommon.c b/src/wcmCommon.c
> index 315aa4e..f7a8f63 100644
> --- a/src/wcmCommon.c
> +++ b/src/wcmCommon.c
> @@ -906,14 +906,13 @@ void wcmEvent(WacomCommonPtr common, unsigned int
> channel,
> }
>
> /* Optionally filter values only while in proximity */
> - if (common->wcmModel->FilterRaw &&
> - ds.proximity && ds.device_type != PAD_ID)
> + if (ds.proximity && ds.device_type != PAD_ID)
> {
> /* Start filter fresh when entering proximity */
> if (!pLast->proximity)
> wcmResetSampleCounter(pChannel);
>
> - common->wcmModel->FilterRaw(common,pChannel,&ds);
> + wcmFilterCoord(common,pChannel,&ds);
> }
>
> /* skip event if we don't have enough movement */
> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
> index e1997aa..06f8655 100644
> --- a/src/wcmUSB.c
> +++ b/src/wcmUSB.c
> @@ -22,7 +22,6 @@
> #endif
>
> #include "xf86Wacom.h"
> -#include "wcmFilter.h"
>
> #include <asm/types.h>
> #include <linux/input.h>
> @@ -76,7 +75,6 @@ static struct _WacomModel mname = \
> .GetRanges = usbWcmGetRanges, \
> .Start = usbStart, \
> .Parse = usbParse, \
> - .FilterRaw = wcmFilterCoord, \
> .DetectConfig = usbDetectConfig, \
> };
>
> diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h
> index 891f6a6..8b15548 100644
> --- a/src/xf86WacomDefs.h
> +++ b/src/xf86WacomDefs.h
> @@ -128,8 +128,6 @@ struct _WacomModel
> int (*GetRanges)(InputInfoPtr pInfo);
> int (*Start)(InputInfoPtr pInfo);
> int (*Parse)(InputInfoPtr pInfo, const unsigned char* data, int
> len);
> - int (*FilterRaw)(WacomCommonPtr common, WacomChannelPtr pChannel,
> - WacomDeviceStatePtr ds);
> int (*DetectConfig)(InputInfoPtr pInfo);
> };
>
> --
> 1.7.3.4
>
>
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
