Hi Chris,
I wouldn't worry about it too much, my use case is probably not too
common: I wanted to use the touch screen as a touch pad when connected
to an external monitor, so I was going to put the touch screen in
relative mode, disable button 1 and remap button 3 to button 1. My
patch worked reasonably well in this scenario, but I wanted to be able
to click by tapping, so I ended up writing my own gesture code. This
code is not ready for public consumption (and I don't know if it ever
will be). I do have a patch for you, though: There is no reason to do
any gesture processing if gestures are disabled (this can cause
unexpected fallout when modifying the non-gesture codepath).
In any case, since there doesn't seem to be an easy fix, I doubt it's
worth pursuing this any further -- I feel pretty strongly that gesture
processing should happen in user space anyway.
Thanks,
Tom
On 10/09/2011 11:25 PM, Chris Bagwell wrote:
> On Sun, Oct 9, 2011 at 11:46 AM, Thomas Jaeger <thjae...@gmail.com> wrote:
>> Sorry, please ignore this patch. This is not quite the behavior we need
>> as it leads a left-click once the cursor is moved.
>>
>> On 10/09/2011 12:41 PM, Thomas Jaeger wrote:
>>> I can't conceive of any reason why the current behavior would be preferable.
>>>
>
> Hi Thomas,
>
> Is your right click gesture right now: 1 finger touch+hold then tap
> second finger?
>
> I can see why your interested in suggested patch with that gesture.
>
> I'm working in this general area and I'm debating on what I want to do
> with 2-finger taps. I prefer the Synaptic's and Mac Trackpad 2-finger
> tap (touch 2 fingers and then release 2 fingers in short time span)
> and my original plan was to convert driver to this approach; which
> would have a side affect of fixing your issue.
>
> I believe the current code is modelled on Windows 7 behaviour and
> maybe to Wacom's custom driver behaviour on older Windows. Not sure
> since I don't use Windows that much.
>
> So maybe I need to take a poll or something and see what approach ours
> should use.
>
> If we do keep Windows 7 behaviour then I gotta figure out what that
> means for the normal left click during touch on touchscreens. I
> guess we must leave the left click there even while in
> GESTURE_TAP_MODE or else you'll get the bad behaviour you pointed out.
>
> Hmm, we will need quite some more code cleanup to do that part right.
>
> Chris
>From 3a6e67fb0586e7cbdcd26d43106c1bc91e630d4e Mon Sep 17 00:00:00 2001
From: Thomas Jaeger <thjae...@gmail.com>
Date: Mon, 10 Oct 2011 13:39:40 -0400
Subject: [PATCH] Skip all gesture processing if gestures are disabled
Signed-off-by: Thomas Jaeger <thjae...@gmail.com>
---
src/wcmTouchFilter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/wcmTouchFilter.c b/src/wcmTouchFilter.c
index b6486a5..25d1f31 100644
--- a/src/wcmTouchFilter.c
+++ b/src/wcmTouchFilter.c
@@ -242,7 +242,7 @@ void wcmGestureFilter(WacomDevicePtr priv, int channel)
}
if (!common->wcmGesture)
- goto ret;
+ return;
/* When 2 fingers are in proximity, it must always be in one of
* the valid 2 fingers modes: LAG, SCROLL, or ZOOM.
--
1.7.4.1
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
