Dnia 2011-10-20, czw o godzinie 15:19 -0700, Ping Cheng pisze:
> On Tue, Oct 18, 2011 at 12:18 PM, Przemo Firszt <prz...@firszt.eu> wrote:
> > Please test & comment. I cannot convince git to block text in a
> > different way - if anyone knows how to do it please let me know.
> 
> Can I assume you have tested the driver with your Graphire WL?
I did not test it. My old graphire WL has a new owner now.
Can you test it?

> Why do we need to move INPUT_PROP_POINTER insider case
> GRAPHIRE_BLUETOOTH below? Both Graphire and Intuos4 are POINTER
> devices.
> 
> > -   __set_bit(INPUT_PROP_POINTER, input->propbit);
> > +   __set_bit(BTN_TOOL_PEN, input->keybit);
> > +   __set_bit(BTN_TOOL_RUBBER, input->keybit);
> > +   __set_bit(BTN_TOUCH, input->keybit);
> 
> > -   /* Basics */
> >     input->evbit[0] |= BIT(EV_KEY) | BIT(EV_ABS) | BIT(EV_REL);
> 
> > -   __set_bit(REL_WHEEL, input->relbit);
> > +   switch (hdev->product) {
> > +   case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH:
> > +           __set_bit(INPUT_PROP_POINTER, input->propbit);

I moved everything that was not common with my first (working) driver.
I'll move it to "common" section. Thanks!

-- 
Przemo


------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to