On Sun, Feb 5, 2012 at 8:08 AM, Przemo Firszt <[email protected]> wrote: > Dnia 2012-02-04, sob o godzinie 10:52 -0600, Chris Bagwell pisze: > Chris, > irst of all - thanks for your comments! >> I've been monitoring battery topics lately (no pun intended :-) ) >> because I'm adding adding similar logic to wacom_wac for wireless. I >> know that the function power_supply_powers() that is in stack trace is >> brand new (not in official kernel) and associates a power supply to a >> specific device (nice so GUI's don't think our wacom's are powering >> our machines). > > It is in the mainline now [1] > >> So I would suspect that feature first. Can you try deleting the two >> calls to that function and see if crash goes away? > > I'm trying to figure out if theat's correct that Jeremy added twice the > same call: power_supply_powers(&wdata->battery, &hdev->dev); instead of: > power_supply_powers(&wdata->battery, &hdev->dev); > and > power_supply_powers(&wdata->ac, &hdev->dev); > It might be the reason - compiling now...
Yeah, that could be issue as well. If I recall correctly, registering the same sysfs file name or directory twice will cause crashes like this. Since that topic came up, I thought I'd bring up a related item. I notice that hid-wacom is installing "wacom_battery" and "wacom_ac". hid-wiimote is only other example input I could find with battery and its registering "wiimote_battery". Since bluetooth is designs to support concurrent devices, I would think this could lead to crashes in the off case that user has multiple tablets. Although 2 Wacom's may not be typical, I would think 2 wiimotes would be. We might should be putting a # on ends of those names like most other areas do. Chris > >> I peeked in jikos's hid tree and the function looks like it registers >> a sysfs directory called "powers". I suspect its meant to be under >> the "wacom_battery" directory and thus the call needs to be moved >> *after* registering the battery device. > > I'll test that as well. > >> This looks needed even for graphire's to work. > > Anyone with Graphire to test it? > > [1] http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds% > 2Flinux.git&a=search&h=HEAD&st=grep&s=power_supply_powers > ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
