It does look like its needed. A #define would have probably prevented this. I quickly grepped for wheel_action[] usage in code and it wasn't obvious to me what its for but I suspect its related to up/down directions (2) times # of wheel-like devices supported (3). wheel_keys[] was more obvious.
So maybe call it a #define for both arrays WCM_MAX_WHEEL_UP_DOWN? But it seems an obvious bug so if you need to submit ASAP: Reviewed-by: Chris Bagwell <[email protected]> On Fri, Feb 17, 2012 at 11:21 AM, Jason Gerecke <[email protected]> wrote: > This array was apparently overlooked when adding support for the > second touch ring present on the 24HD. > > Signed-off-by: Jason Gerecke <[email protected]> > --- > src/xf86WacomDefs.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/xf86WacomDefs.h b/src/xf86WacomDefs.h > index ef425f5..625b07e 100644 > --- a/src/xf86WacomDefs.h > +++ b/src/xf86WacomDefs.h > @@ -298,7 +298,7 @@ struct _WacomDeviceRec > > /* property handlers to listen to for action properties */ > Atom btn_actions[WCM_MAX_BUTTONS]; > - Atom wheel_actions[4]; > + Atom wheel_actions[6]; > Atom strip_actions[4]; > > OsTimerPtr serial_timer; /* timer used for serial number property > update */ > -- > 1.7.8.4 > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > Linuxwacom-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
