On 03/23/2012 07:00 PM, Chris Bagwell wrote: > On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov<spbn...@gmail.com> wrote: >> + /* Center the reported range on zero */ >> + /* FIXME remove once kernel is fixed */ >> + common->wcmTiltXOff = - (absinfo.minimum + absinfo.maximum) >> / 2; > > Why is this a FIXME? It seems reasonable to center to zero here. For > example, there is no intention to "fix" Wacom kernel drivers, are > there?
Well, I intended to "fix" them, actually. The thing is, the existing range wacom drivers use is not straightforward and contradicts HID specification. I was hoping to make a patch for the kernel drivers, so, after a while (at your discretion), this centering could be dropped. > If their driver is updated to send min/max (or are they already?), then > this logic is still needed for them to continue working as expected. Judging from the code, it seems wacom kernel drivers send meaningful min/max values already. However, I was hoping some of linuxwacom developers could verify this. > I'd resolve first (if anything to resolve) and delete FIXME before submitting. Resolving kernel first creates a window where the X driver won't work. > I've no other comments other than I hope a Intuos user can test patch first. Can you point me to one, so I could ask directly? Thanks! Sincerely, Nick ------------------------------------------------------------------------------ This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http://p.sf.net/sfu/sfd2d-msazure _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
