On Thu, Sep 27, 2012 at 3:20 PM, Jason Gerecke <killert...@gmail.com> wrote: > On Thu, Sep 27, 2012 at 1:56 PM, Ping Cheng <pingli...@gmail.com> wrote: > >> BTW, this code from [1] does not fit what I understood >> >> + * - First ring (group 0) uses LED 0 >> + * - Second ring (group 1) uses LED 1 >> + * - First touchstrip (group 2) uses LED 1 >> + * - Second touchstrip (group 3) uses LED 0 >> >> There are two cases, tablet has one set of expresskeys; and tablet >> has two sets of expresskeys. >> >> If there is only one set of expresskeys, ring or touchstrip will and >> can only use LED 0; >> If there are two sets of expresskeys, the left set (i.e., your first >> ring/touchstrip) uses LED 1; the right set, your second >> ring/touchstrip, uses LED 0. >> >> [1] https://bugzilla.gnome.org/attachment.cgi?id=214732&action=edit > > Not to get off-topic, but do we want to consider revising this > interface to make it more logical? Having the "first" ring/strip being > controlled by the "second" LED control (and vice versa) rubs me the > wrong way. I'd consider it a bug, except that its the documented > behavior. I'm not sure it qualifies as a "grave error" that Dmitry > would allow to be changed, but it'd make more sense to fix it in the > kernel than to rely on libwacom to describe the quirk.
I think we are not talking the same thing. Maybe I didn't make myself clear. Let me try it again. I meant the four lines should read something like: + * - First ring (group 0) uses LED 1 + * - Second ring (group 1) uses LED 0 + * - First touchstrip (group 2) uses LED 1 + * - Second touchstrip (group 3) uses LED 0 That is, no matter it is ring or touchstrip, the one in the first group should use LED 1, the one in the second group uses LED 0. The kernel driver is consistent in this sense. And this is for tablets with two sets of LEDs. If there is only one set of LEDs, such as Intuos 4 and 5, only LED 0 can be used. Ping ------------------------------------------------------------------------------ Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
