The load test will issue a critical warning in libwacom, which is to be expected since it's asking for the flags of a non-existing button.

Yet this may confuse some contributors who (like me) would spent a bit of time suspecting a regression introduced by a recent change.

The proposed (trivial) patch justs print a message informing that the critical warning in libwacom is expected.

>From 3069334c4f1e8b28f15bdf165495ecddd9998080 Mon Sep 17 00:00:00 2001
From: Olivier Fourdan <ofour...@redhat.com>
Date: Wed, 17 Oct 2012 10:23:51 +0200
Subject: [PATCH] test: load test will issue a critical warning

which is expected since it asks for a button that
does not exist, but that may confuse developpers.

Add a statement that the critical warning is expected.

Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
---
 test/load.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/test/load.c b/test/load.c
index b449fa6..9c528e0 100644
--- a/test/load.c
+++ b/test/load.c
@@ -100,6 +100,11 @@ int main(int argc, char **argv)
 
 	assert(libwacom_get_button_flag(device, 'A') & WACOM_BUTTON_RING_MODESWITCH);
 	assert(libwacom_get_button_flag(device, 'I') & WACOM_BUTTON_OLED);
+	/*
+	 * I4 WL has only 9 buttons, asking for a 10th button will raise a warning
+	 * in libwacom_get_button_flag() which is expected.
+	 */ 
+	printf("Following critical warning in libwacom_get_button_flag() is expected\n");
 	assert(libwacom_get_button_flag(device, 'J') == WACOM_BUTTON_NONE);
 	assert(libwacom_get_ring_num_modes(device) == 4);
 
-- 
1.7.1

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to