Hi Peter, Thanks for your review.
Peter Hutterer said the following on 11/01/2012 07:10 AM: > please sign off your patches. Done. > ACK to the patch, but a few comments: > - should we call this svgdata or something like that instead of the generic > "Images"? in the makefile you call it "layouts" which I think is a more > approprate name than images. Done, changed [Ii]mage(s) to [Ll]ayout(s) > - can we join the lines in the svg data? seems like a new line for every xml > attribute makes the file excessively long. there aren't many attributes, so > joining them on one line with a bit of nice spacing looks good enough as > well, imo: > <rect id="ButtonA" class="A Button" x="40" y="54" width="11" height="17"/> > <text id="LabelA" class="A Label" x="60" y="63"> A</text> > <rect id="ButtonB" class="B Button" x="40" y="72" width="11" height="17"/> > .. Done, tough I am not sure it improves readability, ymmv :) > Please make sure you always have -Wall in your CFLAGS. THe show-svg-image > tool generates 15 warnings here. tablet-svg-validity has a few as well. Fixed. > but please sign off the patch before pushing Done. New series of 4 updates patches follow. ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
