On Wed, Nov 14, 2012 at 4:45 PM, Peter Hutterer <peter.hutte...@who-t.net>wrote:
> On Wed, Nov 14, 2012 at 01:13:59PM -0800, Jason Gerecke wrote:
> > From: Your Name <y...@example.com>
>
> you probably want to fix that up? :)
>
> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
>
>
> >
> > What we want to do is clear all 256 steps of an individual action. What
> > we were doing was clearing just the first step. This resulted in the
> > following behavior:
> >
> > $ xsetwacom --set <id> Button 1 "key a b c" # press button 1 -> abc
> > $ xsetwacom --set <id> Button 1 "key d" # press button 1 -> dbc
> WRONG!
> >
> > Signed-off-by: Jason Gerecke <killert...@gmail.com>
> > ---
> > src/wcmXCommand.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
> > index d53df08..922c80f 100644
> > --- a/src/wcmXCommand.c
> > +++ b/src/wcmXCommand.c
> > @@ -433,7 +433,7 @@ static int wcmSetActionProperty(DeviceIntPtr dev,
> Atom property,
> >
> > if (!checkonly && prop)
> > {
> > - memset(action, 0, sizeof(action));
> > + memset(action, 0, sizeof(*action));
> > for (i = 0; i < prop->size; i++)
> > (*action)[i] = ((unsigned int*)prop->data)[i];
> > *handler = property;
> > --
> > 1.8.0
> >
> >
> >
> ------------------------------------------------------------------------------
> > Monitor your physical, virtual and cloud infrastructure from a single
> > web console. Get in-depth insight into apps, servers, databases, vmware,
> > SAP, cloud infrastructure, etc. Download 30-day Free Trial.
> > Pricing starts from $795 for 25 servers or applications!
> > http://p.sf.net/sfu/zoho_dev2dev_nov
> > _______________________________________________
> > Linuxwacom-devel mailing list
> > Linuxwacom-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> >
>
That's what I get for making the commit on a machine I don't normally work
with :D
Jason
---
When you're rife with devastation / There's a simple explanation:
You're a toymaker's creation / Trapped inside a crystal ball.
And whichever way he tilts it / Know that we must be resilient
We won't let them break our spirits / As we sing our silly song.
------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
