On Tue, Dec 04, 2012 at 12:30:32PM -0800, Ping Cheng wrote: > On Tue, Dec 4, 2012 at 2:29 AM, Olivier Fourdan <ofour...@redhat.com> wrote: > > Hi, > > > > It's been reported [1] that some serial tablet are wrongly seen as "Wacom > > Serial Tablet WACf004". > > > > Looking at the device definition in libwacom, it appears that the > > DeviceMatch for the serial-wacf004.tablet is serial:0000:0000 so I suspect > > any unknown serial tablet will be reported as a "WACf004". > > I wonder how a serial device ever gets a serial:0000:0000. We assign > vendor id and device id to all serial devices in the kernel and X > drivers.
libwacom is independent of the X driver, it goes by the kernel. but you're right, the kernel data should be enough to identify the tablet. we still have code in libwacom where the product/vendor may end up as 0/0 but I don't know if that code is still hit. quick check on the WACf00e i have here is that if the tablet is inputattached it works fine, but if it's handled as raw serial device libwacom doesn't see it. I wonder if that's where this comes from? Cheers, Peter > > > The attached patch therefore changes the current definition of > > serial-wacf004.tablet to a more generic dfefintion, thus the name > > generic-serial.tablet and the new name "Generic Serial Tablet". > > If we have no idea about the device id, we can not tell the device > type and its supported feature. Naming it generic is a good choice. > > Reviewed-by: Ping Cheng <pingli...@gmail.com> > > Ping > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
