On Thu, Sep 12, 2013 at 4:20 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Wed, Sep 11, 2013 at 06:01:49PM -0700, Ping Cheng wrote: >> New Cintiq/Intuos Pro Pen looks very close to the existing Classic >> Pen. Use the Classic image so we do not have to create a new one >> for Pro Pen since the person who planned to add an image for Pro >> Pen does not have time to work on this project any more. > > if it's just the image, wouldn't it be easier to duplicate the image and fix > it at a future point but leave the database entry correct? > or am I missing something here? > > Cheers, > Peter >
If it was our own sandbox we'd be playing in, sure :) I'm not sure GNOME would accept a patch that just duplicated an image, and neither Ping nor I have the time to make a proper graphic. Actually, in hindsight, I don't much like the "Type=Pro" designation. We have pens spanning from the original Intuos through the Intuos 4 which area all categorized as one of Classic, General, Inking, Marker, or Airbrush. What is so special about this pen that requires a brand new type designation? The industrial design? By that logic, we'd have a dozen or more types... If we want g-c-c to have silhouettes that match the industrual design, we should probably have it make use of the pen ID instead. What is the type field for? What do its values *mean*? I'd rather not push any patches until we know what the right way forward is. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... > >> >> Signed-off-by: Ping Cheng <pi...@wacom.com> >> --- >> data/libwacom.stylus | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/data/libwacom.stylus b/data/libwacom.stylus >> index a4fa8ba..290fe5e 100644 >> --- a/data/libwacom.stylus >> +++ b/data/libwacom.stylus >> @@ -134,7 +134,7 @@ Type=Classic >> Name=Pro Pen >> HasEraser=true >> Buttons=2 >> -Type=Pro >> +Type=Classic >> >> [0x180802] >> # DTH2242 Pen >> @@ -247,7 +247,7 @@ Type=General >> # Cintiq 13HD >> Name=Pro Pen Eraser >> IsEraser=true >> -Type=Pro >> +Type=Classic >> >> [0x18080a] >> # DTH2242 Eraser >> -- >> 1.8.1.2 >> > > ------------------------------------------------------------------------------ > How ServiceNow helps IT people transform IT departments: > 1. Consolidate legacy IT systems to a single system of record for IT > 2. Standardize and globalize service processes across IT > 3. Implement zero-touch automation to replace manual, redundant tasks > http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk > _______________________________________________ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
