Adds -Werror and -Wextra to the list of kernel CFLAGS so that we can be made aware of more potential issues with the code.
-Wunused-parameter is explicitly disabled because unused parameters are quite common throughout the kernel, producing copious amounts of noise. -Wmissing-field-initializers is explicitly disabled because wacom_wac.c relies heavily on implicit initialization (despite not being "officially" supported by the gnu89 standard). Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> --- 2.6.30/Makefile.in | 2 +- 2.6.36/Makefile.in | 2 +- 2.6.38/Makefile.in | 2 +- 3.17/Makefile.in | 2 +- 3.7/Makefile.in | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/2.6.30/Makefile.in b/2.6.30/Makefile.in index bdabfe0..e2e7727 100644 --- a/2.6.30/Makefile.in +++ b/2.6.30/Makefile.in @@ -6,7 +6,7 @@ ifneq ($(KERNELRELEASE),) ifneq ($(CONFIG_USB_WACOM),y) WCM_VERSION := $(shell cd $(KBUILD_EXTMOD)/.. && ./git-version-gen) -ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" +ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers wacom-objs := wacom_wac.o wacom_sys.o obj-m += wacom.o obj-m += wacom_w8001.o diff --git a/2.6.36/Makefile.in b/2.6.36/Makefile.in index bdabfe0..e2e7727 100644 --- a/2.6.36/Makefile.in +++ b/2.6.36/Makefile.in @@ -6,7 +6,7 @@ ifneq ($(KERNELRELEASE),) ifneq ($(CONFIG_USB_WACOM),y) WCM_VERSION := $(shell cd $(KBUILD_EXTMOD)/.. && ./git-version-gen) -ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" +ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers wacom-objs := wacom_wac.o wacom_sys.o obj-m += wacom.o obj-m += wacom_w8001.o diff --git a/2.6.38/Makefile.in b/2.6.38/Makefile.in index 3e7168e..1e5978c 100644 --- a/2.6.38/Makefile.in +++ b/2.6.38/Makefile.in @@ -6,7 +6,7 @@ ifneq ($(KERNELRELEASE),) ifneq ($(CONFIG_USB_WACOM),y) WCM_VERSION := $(shell cd $(KBUILD_EXTMOD)/.. && ./git-version-gen) -ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" +ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers wacom-objs := wacom_wac.o wacom_sys.o obj-m += wacom.o obj-m += wacom_w8001.o diff --git a/3.17/Makefile.in b/3.17/Makefile.in index b41b1c6..69b19e1 100644 --- a/3.17/Makefile.in +++ b/3.17/Makefile.in @@ -6,7 +6,7 @@ ifneq ($(KERNELRELEASE),) ifneq ($(CONFIG_HID_WACOM),y) WCM_VERSION := $(shell cd $(KBUILD_EXTMOD)/.. && ./git-version-gen) -ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" +ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers wacom-objs := wacom_wac.o wacom_sys.o obj-m += wacom.o obj-m += wacom_w8001.o diff --git a/3.7/Makefile.in b/3.7/Makefile.in index c455b31..7d6db95 100644 --- a/3.7/Makefile.in +++ b/3.7/Makefile.in @@ -6,7 +6,7 @@ ifneq ($(KERNELRELEASE),) ifneq ($(CONFIG_USB_WACOM),y) WCM_VERSION := $(shell cd $(KBUILD_EXTMOD)/.. && ./git-version-gen) -ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" +ccflags-y := -DWACOM_VERSION_SUFFIX=\"-$(WCM_VERSION)\" -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers wacom-objs := wacom_wac.o wacom_sys.o obj-m += wacom.o obj-m += wacom_w8001.o -- 2.6.2 ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel