On Monday, August 29, 2016, Peter Hutterer <peter.hutte...@who-t.net> wrote:
> Not adding the actual StripsNumModes entry because this would require > callers > to display an OSD for mode changes. Right now callers (GNOME anyway) relies > on LEDs to show the mode, Can you add the connection between LED and mode to the comments of https://sourceforge.net/p/linuxwacom/libwacom/ci/master/tree/data/wacom.example ? Except that, the patch is fine. > not an on-screen notification. Also, since the modes > are completely caller-controlled without any LEDs the caller could implement > any number of modes, not just what libwacom suggests. > > Add the modes as a comment so we have an explanation. > > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net <javascript:;>> Reviewed-by: Ping Cheng <pi...@wacom.com> Thanks, Ping > --- > data/cintiq-22hd.tablet | 3 +++ > data/cintiq-22hdt.tablet | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/data/cintiq-22hd.tablet b/data/cintiq-22hd.tablet > index 54f3219..bfdffcd 100644 > --- a/data/cintiq-22hd.tablet > +++ b/data/cintiq-22hd.tablet > @@ -54,3 +54,6 @@ Right=K;L;M;N;J;O;P;Q;R > > Touchstrip=A > Touchstrip2=J > +# This tablet has mode buttons but no LEDs to signal the current mode to > the > +# user and thus requires the caller to display an on-screen notification. > +# StripsNumModes=4 > diff --git a/data/cintiq-22hdt.tablet b/data/cintiq-22hdt.tablet > index 9e74c41..6258436 100644 > --- a/data/cintiq-22hdt.tablet > +++ b/data/cintiq-22hdt.tablet > @@ -56,3 +56,6 @@ Right=K;L;M;N;J;O;P;Q;R > > Touchstrip=A > Touchstrip2=J > +# This tablet has mode buttons but no LEDs to signal the current mode to > the > +# user and thus requires the caller to display an on-screen notification. > +# StripsNumModes=4 > -- > 2.7.4 > > > ------------------------------------------------------------ > ------------------ > _______________________________________________ > Linuxwacom-devel mailing list > Linuxwacom-devel@lists.sourceforge.net <javascript:;> > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel >
------------------------------------------------------------------------------
_______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
