A few nitpicks.
First, this isn't a backport of an upstream patch, so the 'backport'
tag should be removed from the commit subject.
On Tue, Jan 9, 2018 at 10:51 AM, Aaron Armstrong Skomra
<sko...@gmail.com> wrote:
> Remove complier warnings.
>
I'd be nice to have an example of the warning being fixed.
(it seems like this should be fixing a -Wmaybe-uninitialized warning,
but I don't see a a codepath that leaves these uninitialized...)
> Signed-off-by: Aaron Armstrong Skomra <sko...@gmail.com>
> ---
> 2.6.30/wacom_wac.c | 2 +-
> 2.6.36/wacom_wac.c | 2 +-
> 2.6.38/wacom_wac.c | 2 +-
> 3.7/wacom_wac.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/2.6.30/wacom_wac.c b/2.6.30/wacom_wac.c
> index 5aeb18311506..d33532889e61 100644
> --- a/2.6.30/wacom_wac.c
> +++ b/2.6.30/wacom_wac.c
> @@ -1625,7 +1625,7 @@ static int wacom_mspro_pad_irq(struct wacom_wac *wacom)
> struct input_dev *input = wacom->input;
> int nbuttons = features->numbered_buttons;
> bool prox;
> - int buttons, ring, ringvalue, keys;
> + int buttons = 0, ring = 0, keys = 0, ringvalue;
Initialized variables should be moved above all uninitialized variables.
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
> bool active = false;
>
> switch (nbuttons) {
> diff --git a/2.6.36/wacom_wac.c b/2.6.36/wacom_wac.c
> index 3d1576256141..ee9edaf49012 100644
> --- a/2.6.36/wacom_wac.c
> +++ b/2.6.36/wacom_wac.c
> @@ -1392,7 +1392,7 @@ static int wacom_mspro_pad_irq(struct wacom_wac *wacom)
> struct input_dev *input = wacom->input;
> int nbuttons = features->numbered_buttons;
> bool prox;
> - int buttons, ring, ringvalue;
> + int buttons = 0, ring = 0, keys = 0, ringvalue;
> bool active = false;
>
> switch (nbuttons) {
> diff --git a/2.6.38/wacom_wac.c b/2.6.38/wacom_wac.c
> index 066c9480d7db..5b7a963d3f03 100644
> --- a/2.6.38/wacom_wac.c
> +++ b/2.6.38/wacom_wac.c
> @@ -1838,7 +1838,7 @@ static int wacom_mspro_pad_irq(struct wacom_wac *wacom)
> struct input_dev *input = wacom->input;
> int nbuttons = features->numbered_buttons;
> bool prox;
> - int buttons, ring, ringvalue, keys;
> + int buttons = 0, ring = 0, keys = 0, ringvalue;
> bool active = false;
>
> switch (nbuttons) {
> diff --git a/3.7/wacom_wac.c b/3.7/wacom_wac.c
> index 0a2e535f6d45..2bf3535a5a06 100644
> --- a/3.7/wacom_wac.c
> +++ b/3.7/wacom_wac.c
> @@ -1820,7 +1820,7 @@ static int wacom_mspro_pad_irq(struct wacom_wac *wacom)
> struct input_dev *input = wacom->input;
> int nbuttons = features->numbered_buttons;
> bool prox;
> - int buttons, ring, ringvalue, keys;
> + int buttons = 0, ring = 0, keys = 0, ringvalue;
> bool active = false;
>
> switch (nbuttons) {
> --
> 1.7.9.5
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
