On Tue, Mar 06, 2018 at 09:01:03AM -0800, Jason Gerecke wrote:
> From: Daniel Ferguson <danielfergu...@me.com>
> 
> Refactoring in (527fa95c29) introduced a typo in wcmFilterCoord which
> resulted in the value of tilt x being assigned to tilt y.
> 
> Ref: https://github.com/linuxwacom/xf86-input-wacom/issues/11
> Fixes: 527fa95c29 ("Refactor coordinate averaging to seperate function")
> Signed-off-by: Daniel Ferguson <danielfergu...@me.com>
> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com>
> ---
> Mailinglist review of the following pull request:
>     https://github.com/linuxwacom/xf86-input-wacom/pull/12

Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>

Cheers,
   Peter

> 
>  src/wcmFilter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/wcmFilter.c b/src/wcmFilter.c
> index 15ce1c8..c34b592 100644
> --- a/src/wcmFilter.c
> +++ b/src/wcmFilter.c
> @@ -314,7 +314,7 @@ int wcmFilterCoord(WacomCommonPtr common, WacomChannelPtr 
> pChannel,
>               else if (ds->tiltx < common->wcmTiltMinX)
>                       ds->tiltx = common->wcmTiltMinX;
>  
> -             ds->tilty = wcmFilterAverage(state->tiltx, 
> common->wcmRawSample);
> +             ds->tilty = wcmFilterAverage(state->tilty, 
> common->wcmRawSample);
>               if (ds->tilty > common->wcmTiltMaxY)
>                       ds->tilty = common->wcmTiltMaxY;
>               else if (ds->tilty < common->wcmTiltMinY)
> -- 
> 2.16.2
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to