On Fri, Apr 20, 2018 at 03:00:10PM -0700, Jason Gerecke wrote:
> On Tue, Apr 17, 2018 at 9:17 PM, Peter Hutterer
> <peter.hutte...@who-t.net> wrote:
> > On Tue, Apr 17, 2018 at 10:53:17AM -0700, Jason Gerecke wrote:
> >> Ref: https://github.com/linuxwacom/libwacom/issues/15
> >> Signed-off-by: Jason Gerecke <killert...@gmail.com>
> >> ---
> >> data/elan-22e2.tablet | 17 +++++++++++++++++
> >> 1 file changed, 17 insertions(+)
> >> create mode 100644 data/elan-22e2.tablet
> >>
> >> diff --git a/data/elan-22e2.tablet b/data/elan-22e2.tablet
> >> new file mode 100644
> >> index 0000000..98b70dd
> >> --- /dev/null
> >> +++ b/data/elan-22e2.tablet
> >> @@ -0,0 +1,17 @@
> >> +# Used in the HP Spectre X360
> >> +
> >> +[Device]
> >> +Name=ELAN 22E2
> >> +DeviceMatch=i2c:04f3:22e2
> >
> > missing:
> > Class=ISDV4
> >
> > Or some other one? ./test/tablet-validity trips up on this
> >
> > Cheers,
> > Peter
> >
>
> Whoops, good catch. Guess I didn't push this set up to Travis before
> whisking them off to the mailinglist.
>
> This isn't a Wacom device, so ISDV4 isn't really technically correct,
> but its probably close enough for all libwacom and its callers care.
> The "n-trig-pen.tablet" definition also uses the ISDV4 class, so
> there's definitely precedent too.
And afaict, nothing uses the class bit anyway.
repoquery --whatrequires libwacom
tells me the only packages are gnome-control-center, mutter,
gnome-settings-daemon, cinnamon-control-center and libinput.
I grep'd all of them for WCLASS and all I got was a tumbleweed hitting me in
the face. I think we should deprecate libwacom_get_class() to make sure new
users of libwacom don't start using it. Whatever purpose it was supposed to
serve 6+ years ago, it clearly doesn't.
Cheers,
Peter
>
> Jason
> ---
> Now instead of four in the eights place /
> you’ve got three, ‘Cause you added one /
> (That is to say, eight) to the two, /
> But you can’t take seven from three, /
> So you look at the sixty-fours....
>
> >> +IntegratedIn=Display;System
> >> +Styli=0xfffff;0xffffe
> >> +
> >> +[Features]
> >> +Stylus=true
> >> +Reversible=false
> >> +Touch=false
> >> +TouchSwitch=false
> >> +Ring=false
> >> +Ring2=false
> >> +NumStrips=0
> >> +Buttons=0
> >> --
> >> 2.17.0
> >>
> >>
> >> ------------------------------------------------------------------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> _______________________________________________
> >> Linuxwacom-devel mailing list
> >> Linuxwacom-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> >>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
