On Fri, Apr 20, 2018 at 4:31 PM, Ping Cheng <pingli...@gmail.com> wrote: > On Fri, Apr 20, 2018 at 2:33 PM, Jason Gerecke <killert...@gmail.com> wrote: >> >> The config.h header that is generated after running the configure >> script should be included by all the kernels to ensure that we are >> able to access compiler defines only discovered at config time. > > > How come we didn't include it before? I guess we didn't fully utilize the > whole features of configure ;). >
That's exactly the case. The configure script for input-wacom has been pretty bare-bones so it hasn't been necessary to include them. They were only added to the 3.7 and 3.17 trees last month as part of Benjamin's RHEL 7.5 powersupply fixes. I want to use the same kind of compile-time detection logic so just copied his include. Based on Peter's comments on this patch and the next, we might want to take a second look at that fix to e.g. check srcdir != builddir and the style of our config flag macros. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... >> >> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com> > > > Reviewed-by: Ping Cheng <ping.ch...@wacom.com> > > Cheers, > Ping > >> --- >> 2.6.32/wacom.h | 1 + >> 2.6.38/wacom.h | 1 + >> 4.5/wacom.h | 1 + >> 3 files changed, 3 insertions(+) >> >> diff --git a/2.6.32/wacom.h b/2.6.32/wacom.h >> index b023fdb..2d87346 100755 >> --- a/2.6.32/wacom.h >> +++ b/2.6.32/wacom.h >> @@ -82,6 +82,7 @@ >> */ >> #ifndef WACOM_H >> #define WACOM_H >> +#include "../config.h" >> #include <linux/kernel.h> >> #include <linux/slab.h> >> #include <linux/module.h> >> diff --git a/2.6.38/wacom.h b/2.6.38/wacom.h >> index 357f5e8..1e5d848 100644 >> --- a/2.6.38/wacom.h >> +++ b/2.6.38/wacom.h >> @@ -82,6 +82,7 @@ >> */ >> #ifndef WACOM_H >> #define WACOM_H >> +#include "../config.h" >> #include <linux/kernel.h> >> #include <linux/slab.h> >> #include <linux/module.h> >> diff --git a/4.5/wacom.h b/4.5/wacom.h >> index 6bef5a5..2a29d4b 100644 >> --- a/4.5/wacom.h >> +++ b/4.5/wacom.h >> @@ -85,6 +85,7 @@ >> */ >> #ifndef WACOM_H >> #define WACOM_H >> +#include "../config.h" >> #include <linux/kernel.h> >> #include <linux/slab.h> >> #include <linux/module.h> >> -- >> 2.17.0 >> > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
