Glad you asked :)
The recommended way is to use `git send-email` if you can. The reason
is that sometimes things get mangled if you use copy/paste. For
example, copying from the terminal may not preserve tab characters,
and some email / webmail clients may insert line breaks where they
shouldn't be. Attaching is a better solution, but still not perfect
since it makes it harder for people to reply with comments on the
patch (they'd have to copy/paste snippets out of the patch rather than
just hitting "reply"). Using 'git send-email' ensures that patches
don't get mangled and places them in the body for easier review; it
can also manage the hands-off sending of multiple patches that make up
a complete set. The only real downside to 'git send-email' is that it
requires some work to get initially set up.
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
On Mon, Aug 13, 2018 at 7:51 AM James Pearson
<jame...@moving-picture.com> wrote:
>
> Sorry if I caused a problem - I just copy-n-pasted the patch into an
> email - should I have included the patch differently (e.g. as an
> attachment) ?
>
> Thanks
>
> James Pearson
>
> Jason Gerecke wrote:
> >
> > Reviewed-by: Jason Gerecke <jason.gere...@wacom.com>
> >
> > I'm having some trouble actually applying this patch to my tree, but I
> > suspect that a recent change to Gmail is probably more the problem
> > than the patch itself.
> >
> > Jason
> > ---
> > Now instead of four in the eights place /
> > you’ve got three, ‘Cause you added one /
> > (That is to say, eight) to the two, /
> > But you can’t take seven from three, /
> > So you look at the sixty-fours....
> >
> >
> > On Wed, Aug 8, 2018 at 3:02 AM James Pearson <jame...@moving-picture.com>
> > wrote:
> >>
> >> Running 'xsetwacom get $id Serial' gives:
> >>
> >> Unknown parameter name 'Serial'.
> >>
> >> 'Serial' should be in the deprecated parameter list - also 'GetTabletID'
> >> is defined twice in the same list
> >>
> >> Signed-off-by: James Pearson <jame...@moving-picture.com>
> >>
> >> tools/xsetwacom.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
> >> index e2810a0..8b66944 100644
> >> --- a/tools/xsetwacom.c
> >> +++ b/tools/xsetwacom.c
> >> @@ -513,7 +513,7 @@ static struct deprecated
> >> {"GetTabletID", "TabletID"},
> >> {"DebugLevel", "ToolDebugLevel"},
> >> {"CommonDBG", "TabletDebugLevel"},
> >> - {"GetTabletID", "TabletID"},
> >> + {"Serial", "BindToSerial"},
> >> {"PressCurve", "PressureCurve"},
> >> {"TPCButton", "TabletPCButton"},
> >> {"CursorProx", "CursorProximity"},
> >> ------------------------------------------------------------------------------
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> _______________________________________________
> >> Linuxwacom-devel mailing list
> >> Linuxwacom-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
