Hi Alberto, all, I would suggest you release a new revision with a refresh of all base LISP specs.
As I'm in, please find below some quick comments: * I would expand the introduction to explain the rationale followed in the spec (e.g., augment ietf-routing). You may also motivate why these are defined as separate modules vs single module with features for each component. * The NMDA statement is missing. * As you are using many identities that are echoing what is in https://www.iana.org/assignments/lisp-parameters/lisp-parameters.xhtml, I wonder whether you considered turning those into an IANA-maintained module. New identities will be added automatically to the module when, e.g., a new act is defined. FWIW, you may refer to RFC9108 or https://datatracker.ietf.org/doc/draft-boucadair-netmod-iana-registries/. * Revealing geo-coordinates information is sensitive. This should be at least mentioned in the security considerations * You may check if the geo-coordinate grouping in https://datatracker.ietf.org/doc/rfc9179/ would be applicable here as well. If not, I would add an explanation why this isn't. * The modules lacks references statements. Please consider adding those to the various modules. * Missing statements: e.g., (1) in the following I guess you should add "must '. >= ../ local-port-low'.." under the local-port-high/ leaf local-port-low { type inet:port-number; description "Low end of local port range."; } leaf local-port-high { type inet:port-number; description "High end of local port range."; } (2) I would use a default statement for 4342 rather than having it in the description leaf ms-udp-port { type uint16; description "Map-Server UDP port (set to 4342)."; } * Some data nodes uses inappropriate types. For example, I suggest you change the name to dscp and use inet:dscp as type. leaf ip-tos { type int32; description "Type of service field."; } * For all the counters, I would suggest you add a discontinuity-time as a device/component may reboot/fail/reset/etc. These counters are likely to be then turned into gauge * Move the examples to an appendix. * To save an IANA question, please add a statement under the IANA section that the modules are not maintained by IANA. Cheers, Med De : lisp <[email protected]> De la part de Alberto Rodriguez-Natal (natal) Envoyé : vendredi 21 juillet 2023 13:45 À : [email protected] Objet : [lisp] LISP YANG Hi all, The LISP YANG model has been stable for quite some time, this is to kindly request if it would be possible to start the WGLC for the document. https://datatracker.ietf.org/doc/html/draft-ietf-lisp-yang Thanks, Alberto ____________________________________________________________________________________________________________ Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration, Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci. This message and its attachments may contain confidential or privileged information that may be protected by law; they should not be distributed, used or copied without authorisation. If you have received this email in error, please notify the sender and delete this message and its attachments. As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified. Thank you.
_______________________________________________ lisp mailing list [email protected] https://www.ietf.org/mailman/listinfo/lisp
