Well the new md5 was around 100x faster for about 2MB of data. Haven't gotten around to writing a decent benchmark suite yet, since my chrome tab crashes at about 4 mb files (see github issue).
The problem seems to be somewhere in the _symmetricEncrypt/Decrypt logic. I was able to reproduce it when using only that code for simple symmetric encryption. I was thinking about using the symmetric encryption and modularizing that code, for use with a webworker. This should be pretty straitforward since there are no references of window/document in there. The high level OpenPGP asymetric encryption would then be used to encrypt file-specific keys. This would also ease file sharing, since I only have to share the symmetric key instead of reencrypting the whole file with the recipient public key. But I still need to do a bit of research how to best design this type of architecture. Tankred Am 18.03.2012 01:01 schrieb "Alex (via OpenPGP.js)" <[email protected]>: > Btw: I would love to see a performance comparison (a nice graph) between > different versions of OpenPGP.js to be used as PR material... > This in conjunction with a nice logo might be very useful to start > advertising our library a bit to attract some more developers... > > Best regards, Alex > > On 17.03.2012, at 12:57, Tankred Hase wrote: > > > Hi, > > > > please review if the patch is correct. Thanks! > > > > Tankred > > > > You can merge this Pull Request by running: > > > > git pull https://github.com/openpgpjs/openpgpjs faster_md5 > > > > Or you can view, comment on it, or merge it online at: > > > > https://github.com/openpgpjs/openpgpjs/pull/37 > > > > -- Commit Summary -- > > > > * added faster md5 implementation > > * generated recources with make minify > > > > -- File Changes -- > > > > M resources/openpgp.js (20181) > > M resources/openpgp.min.js (738) > > M src/ciphers/hash/md5.js (504) > > > > -- Patch Links -- > > > > https://github.com/openpgpjs/openpgpjs/pull/37.patch > > https://github.com/openpgpjs/openpgpjs/pull/37.diff > > > > --- > > Reply to this email directly or view it on GitHub: > > https://github.com/openpgpjs/openpgpjs/pull/37 > > _______________________________________________ > > http://openpgpjs.org >
_______________________________________________ http://openpgpjs.org
