Cool thanks. Ill send you a keypair in order to reproduce the passphrase issue when it happens again.
Tankred Am 29.03.2012 07:16 schrieb "Sean Colyer" <[email protected]>: > I've now merged this pull request into master. > > On Sun, Mar 18, 2012 at 8:00 AM, Tankred Hase <[email protected]> wrote: > >> Ok, I added an new method to util for converting hex to binary strings. >> The OpenPGP.js unit tests complete successfully again. >> >> The API didn't change compared to the old implementation. You get a >> binary MD5 hash by calling 'MD5(entree)'. In addition to that, you can now >> also call 'md5(entree)' for a hex representation without needing to do any >> conversion. >> >> I committed the changes to the new branch. Please review it and if its >> ok, merge it to master. Thanks. >> >> Tankred >> >> Am 18. März 2012 16:26 schrieb Tankred Hase <[email protected]>: >> >> Yeah they all seem to return binary. There seems to be no quickfix since >>> util only provides conversion in one direction... Ill look into it. >>> >>> Tankred >>> Am 18.03.2012 00:58 schrieb "Alex (via OpenPGP.js)" <[email protected] >>> >: >>> >>> Hi Tankred, >>>> >>>> > Should I change the MD5 it to a binary output? >>>> >>>> well, what do the other hash methods return? I think your MD5 >>>> implementation should return the same type... >>>> >>>> Best regards, Alex >>>> >>>> On 17.03.2012, at 13:20, Tankred Hase wrote: >>>> >>>> > Ooops... The OpenPGP.js unit test for MD5 seem to bee failing since >>>> the new implementation returns hex and the test apply util.hexstrdump on >>>> the result. Should I change the MD5 it to a binary output? >>>> > >>>> > Tankred >>>> > >>>> > Am 17. März 2012 22:52 schrieb Tankred Hase <[email protected]>: >>>> > Hi, >>>> > >>>> > I'm using MD5 since the google app engine blob-store uses it. I had >>>> some trouble with the current MD5 implementation, it also seemed to be a >>>> bit slow. I looked around a bit and added a faster implementation. >>>> > >>>> > I created a branch on github... please review the changes: >>>> https://github.com/openpgpjs/openpgpjs/compare/faster_md5 Thanks! >>>> > >>>> > Tankred >>>> > >>>> > _______________________________________________ >>>> > >>>> > http://openpgpjs.org >>>> >>>> _______________________________________________ >>>> >>>> http://openpgpjs.org >>>> >>> >> >> _______________________________________________ >> >> http://openpgpjs.org >> >> > > _______________________________________________ > > http://openpgpjs.org > >
_______________________________________________ http://openpgpjs.org
