Ah, yes, we do have a dependency there. That code as you might note from the header is taken from this project: https://github.com/gildas-lormeau/zip.js
I've modified the zip.js file by basically stripping out all of the things we're not using (everything except decompression) just so that I have it configured in the same style as the original project. We could presumably merge these into one file at no expense. In my testing I haven't been using the minified version of the file, and I might be the only one currently using the zip decompression (not sure). I use it in my gmail chrome extension: https://github.com/seancolyer/gmail-crypt. In my extension I just use the combined but not minified file. My point here is that it's likely that zip decompression had been broken in the .min file for as long as it's been in the project. If you want to look into combining these, feel free. If not, I'll try to when I get some time but I've been pretty swamped lately. Unless you still believe the commits in your pull request have caused this issue, I'll go ahead and merge your current pull request in. Sean On Wed, Jun 20, 2012 at 9:57 AM, Thomas Oberndörfer <[email protected]>wrote: > > Hi there, > > I saw that there is currently a dependency in the execution order of the > two files: > > compression/zip/zip.js > compression/zip/inflate.js > > zip.Inflater will only be defined if the files are executed in the order > above, > otherwise it's undefined. > > The problem (at least on my machine) is that when I call 'make minify' > then the inflate.js > coding is put in front of the zip.js stuff in openpgp.js. > > Did this happend before? A solution could be to merge the two files in one. > > Best regards, > Thomas > > _______________________________________________ > > http://openpgpjs.org > >
_______________________________________________ http://openpgpjs.org
