Thanks for getting back to me. No worries about the breakage: it is the devel branch, and better tests are great! :)
Followup questions: 1. Do you know when the refactoring is likely to complete? 2. Are signature validation failures on the master branch expected? If the devel branch will be in semi-working order soon I'm happy to wait until then to debug the signature validation problem. Thanks, Geoffrey On Sep 21, 2013, at 9:18 AM, Sean Colyer <[email protected]> wrote: > Yeah, for the refactor there were certain aggressive movements that haven't > been fixed yet. Yes, I agree this is annoying. > > In this case what you're looking for got moved to: src/encoding/armor.js > > The upside to this is that we can do some test driven development based on > our existing unit tests and add coverage for things that are broken moving > forward. Good testing is essential for crypto projects and this refactor can > really force our standards up for that. > > Sean > > > On Tue, Sep 10, 2013 at 1:06 AM, Geoffrey Irving <[email protected]> wrote: > openpgp_encoding_deArmor is used in several places in the devel branch, but > defined nowhere. Looks like 1e49e8ee23f08f1387f3b823ae579608dad5a12b renamed > it to use all lower case, then 18236ac09751ee3b36b0e62f359e2631bb8e54c9 > deleted the function definition instead of fixing the uses. > > Geoffrey > > _______________________________________________ > > http://openpgpjs.org > > > _______________________________________________ > > http://openpgpjs.org > Subscribe/unsubscribe: http://list.openpgpjs.org
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ http://openpgpjs.org Subscribe/unsubscribe: http://list.openpgpjs.org
