I'm not sure I see huge advantages for OpenPGP.js using AMD/require.js. It seems a bit cumbersome when I've looked at writing it. I think common.js/browserify approach is more common, and seems an easier path to node support. The build step seems pretty minor to me but I am curious about why AMD has been much better for testing in your experience.
I'm not totally opposed to it, but I'm just not entirely convinced that it's worth switching right now. Do you think it would increase our longterm ability to develop OpenPGP.js? Thoughts? Sean On Wed, Oct 23, 2013 at 11:10 AM, Tankred Hase <[email protected]> wrote: > Hi, > > I've taken a look at the devel branch. If I understand correctly > you're aiming to modularize the components using common.js/node syntax > and build them together using browserify. > > We've worked with browserify in the last 3 months and we have decided > to refactor all of our components to AMD module with require.js, > because it's a lot more flexible. You don't have a mandatory build > step, the code is much more testable and you can still bundle > everything together into one file for deployment. Node.js support also > works great using amdefine: http://requirejs.org/docs/node.html#3 > > If I may, I would like to propose refactoring to AMD and will gladly > do the work if everyone is ok with it. > > Kind regards, > Tankred > _______________________________________________ > > http://openpgpjs.org > Subscribe/unsubscribe: http://list.openpgpjs.org >
_______________________________________________ http://openpgpjs.org Subscribe/unsubscribe: http://list.openpgpjs.org
