Nicholas Bergson-Shilcock wrote: > To recap, here's what I did and how things are working now:
1. Assuming none of the new arguments (sort_on, filter_on or reversed) are specified, the behavior is identical to before, so no existing code should break. 2. If recent_first is set explicitly, a DeprecationWarning is written to the log. 3. You can now choose to filter and sort messages by modification_date (i.e., date of most recent reply) in addition to date (which was previously the only option). 4. I used 'reversed' instead of 'descending' as the boolean argument, since that name is used for the same functionality in the getMessageReferrers method 5. I updated the doc string and interface definition accordingly. Note I changed the default here to be recent_first=False, as this was incorrect before (the docs said True when in the actual implementation it was False). 6. I updated the calls to getToplevelMessages elsewhere in the code to use the new arguments instead of recent_first These changes were made on the ui-improvements branch, which rmarianski and I just merged to trunk.
sounds great! thanks! -r -- Archive: http://www.openplans.org/projects/listen/lists/listen-dev/archive/2009/01/1233269547305 To unsubscribe send an email with subject "unsubscribe" to [email protected]. Please contact [email protected] for questions.
