I'm working on cleaning up the file handling code in bincimapd-copy.cc and as part of that I had to rename the messagedepot::open() method to ...::fopen(). I felt this more accurately reflected the fact that it returned a FILE* instead of a file descriptor. I put in ::open() as one that does return a file descriptor but that is unused at the moment.
Since this patch covers so much of the tree, I'm releasing it as a separate single-purpose patch rather than roll it together with the other changes I'm working on. Being a little lengthy due to all the fact I renamed a rather core function, I've put it up instead of pasting it here.
http://www.technocage.com/~caskey/bincimap/open2fopen-1.0.24.patch
I'll be producing a couple more patches as I work on removing some constants from the bincimapd-copy.cc method. Most of this though is motivated by an effort to eliminate a minor bug in that method and help clean up the IO code in general. Copy will currently fail for any message over 2GB in size (not that it will happen anytime soon).
Elsewhere, in io/io.h in IO::MODE_PLAIN it will fail on EOF when the character 0xfe is read (8859-1 defines it as 'LATIN SMALL LETTER THORN').
My POSIX C skills suck less than my ANSI C++ so my coding efforts are revolving around the parts of the code that use C to get their job done. Hope this helps.
C=)
--
--------------------------------------------------------------------------
Better the hard truth than the comforting fantasy. -- Carl Sagan
--------------------------------------------------------------------------
Caskey <caskey*technocage.com> /// TechnoCage Inc.
--------------------------------------------------------------------------
A presumption on your part does not constitute an obligation on my part.
