On Wed, Feb 25, 2026 at 04:54:29PM -0800, Song Liu wrote:
> find_global_symbol_by_name() already compares names of the two symbols,
> so there is no need to compare them again.
>
> Signed-off-by: Song Liu <[email protected]>
> ---
> tools/objtool/klp-diff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c
> index a3198a63c2f0..57606bc3390a 100644
> --- a/tools/objtool/klp-diff.c
> +++ b/tools/objtool/klp-diff.c
> @@ -454,7 +454,7 @@ static int correlate_symbols(struct elfs *e)
>
> sym2 = find_global_symbol_by_name(e->patched, sym1->name);
>
> - if (sym2 && !sym2->twin && !strcmp(sym1->name, sym2->name)) {
> + if (sym2 && !sym2->twin) {
> sym1->twin = sym2;
> sym2->twin = sym1;
Subject has a typo ("redundent"), and function names are missing "()":
Remove redundant strcmp() in correlate_symbols()
--
Josh
