Frederick Grose wrote:
>     +    if [ -x /sbin/pvs -a \
>     +       "$(/sbin/pvs -o vg_name --noheadings $dev* 2>/dev/null)" ]; then
...
> Redirecting standard error leads to silent failure when the lvm2 tools 
> are not installed.

That's why there's a check for executable first.
Anyway, if lvm2 tools aren't installed, there won't be LVM started, so no 
problem.

> I've suggested leaving out that redirection so as to leave a hint for 
> the user in that situation.

That would be just noise and wouldn't help the user, IMHO it's better not to 
get into error situation by checking for executable.

Thanks,
Alan
--
livecd mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/livecd

Reply via email to