On Mon, Jun 14, 2010 at 15:34:49 -0400, Frederick Grose <[email protected]> wrote: > > Bug 582051 <https://bugzilla.redhat.com/show_bug.cgi?id=582051> - --skipcopy > option in tools_livecd-iso-to-disk destructively overwrites persistent > overlay and home.img should be ready to go.
I took a look at this and I think for it's purpose the intent of your changes seem reasonable. However, I think the man page entry should be expanded for --skipcopy to say precisely what the effects of using it are and a bit about what it is for. I looked through what you did change and for the most part it looked OK. I wouldn't be likely to notice an omition though, as I don't know the code well enough. One part that seemed odd was that part of the overlay code is being skipped now, but the test for the second part that you want done checks for -s $USBMNT/$LIVEOS/$OVERFILE instead of "$overlaysizemb" -gt 0. That seems odd to me. I would have expected you to have used -z "$skipcopy" as a nested if, if you wanted to skip only part of the stuff in that block. But maybe I missed something. I'll copy this into the bug report as well, so it gets tracked better. -- livecd mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/livecd
