On Fri, Jul 23, 2010 at 19:50:56 -0700, Jasper Hartline <[email protected]> wrote: > Attached is a patch that will fix BZ# 509427 involving livecd-creator > crashing hard > when it is unable to mount filesystems immediately during an exception. > > diff -up patch/fs.py.orig patch/fs.py > --- patch/fs.py.orig 2010-07-23 18:17:34.000000000 -0700 > +++ patch/fs.py 2010-07-23 18:18:54.000000000 -0700 > @@ -112,7 +112,7 @@ class BindChrootMount: > if not self.mounted: > return > > - rc = subprocess.call(["/bin/umount", self.dest]) > + rc = subprocess.call(["/bin/umount", "-l", self.dest]) > if rc != 0: > raise MountError("Unable to unmount filesystem at %s" % > self.dest) > self.mounted = False
This seems like a good idea (though I want to do a careful check) even if we fix problem with umounting things correctly. This provides more sane behavior if other bugs trigger similar problems. -- livecd mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/livecd
