On 07/26/2010 08:14 AM, Bruno Wolff III wrote:
This patch will break builds with generic-logos and that package is updated
to be consistent with fedora-logos. I suspect that will happen anyway, but
if this patch is accepted, I'll be filing a but against generic-logos.

The patch is attached and the commit log entry follows:
     Change live.py to use the new location of the vesa splash image.

     fedora-logos recently changed the location it uses for the vesa splash
     image. This breaks (bug 615443) live images built using fedora-logos.
     This patch changes the location that the image is fetched from to match
     the one used by fedora-logos.

     Note that generic-logos hasn't been changed to use the new location yet.
     So this change will break live images built using generic-logos until
     that package is updated to match fedora-logos in where it stores the
     vesa splash image.

I think it would be better to be flexible and tolerant and avoid strict external requirements. See the attached patch.

generic-logos should be bugged anyway.

/Mads

diff --git a/imgcreate/live.py b/imgcreate/live.py
--- a/imgcreate/live.py
+++ b/imgcreate/live.py
@@ -372,10 +372,15 @@
 
     def __copy_syslinux_background(self, isodest):
         background_path = self._instroot + \
-                          "/usr/lib/anaconda-runtime/syslinux-vesa-splash.jpg"
+                          "/usr/share/anaconda/syslinux-vesa-splash.jpg"
 
         if not os.path.exists(background_path):
-            return False
+            # fallback to F13 location
+            background_path = self._instroot + \
+                              "/usr/lib/anaconda-runtime/syslinux-vesa-splash.jpg"
+
+            if not os.path.exists(background_path):
+                return False
 
         shutil.copyfile(background_path, isodest)
 
--
livecd mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/livecd

Reply via email to