Review: Approve
Looks good. Some potentially spurious whitespace, commented on inline.
Diff comments:
> diff --git a/files/check_canonical-livepatch.py
> b/files/check_canonical-livepatch.py
> index 3a13062..e4eaa91 100755
> --- a/files/check_canonical-livepatch.py
> +++ b/files/check_canonical-livepatch.py
> @@ -53,13 +53,15 @@ def check_status():
> line = line.strip()
> if 'State:' in line:
> if 'apply-failed' in line:
> - err_lines.append('Patch failed')
> + err_lines.append('Livepatch failed to apply patches. ')
> elif 'check-failed' in line:
> - err_lines.append('Check failed')
> + err_lines.append('Livepatch failed to check the remote
> service for patches. ')
> elif 'unknown' in line:
> - err_lines.append('Unknown error')
> + err_lines.append('Livepatch reports an unknown error. ')
> + elif 'kernel-upgrade-required' in line:
> + err_lines.append('A kernel upgrade (and reboot) is
> required. ')
> elif 'Machine is not enabled' in line:
> - err_lines.append('Machine is not enabled')
> + err_lines.append('Machine is not enabled. ')
>
> if err_lines:
> err = " ".join(err_lines)
The err_lines above all terminate with whitespace, then you are joining them
with more whitespace. Might want to remove the trailing whitespace from the
above strings.
--
https://code.launchpad.net/~barryprice/canonical-livepatch-charm/+git/canonical-livepatch-charm/+merge/355063
Your team Livepatch charm developers is subscribed to branch
canonical-livepatch-charm:master.
--
Mailing list: https://launchpad.net/~livepatch-charmers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~livepatch-charmers
More help : https://help.launchpad.net/ListHelp
