I annotated two places to be changed (libdebugserver.cpp in CMakeLists, and the name of the codesign identity. Other than that, LGTM.
================ Comment at: tools/debugserver/source/MacOSX/CMakeLists.txt:47 @@ +46,3 @@ +# Sign the debugserver binary +set (CODESIGN_IDENTITY lldb) +set (CODESIGN_ALLOCATE /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate) ---------------- This should be the same as in Xcode: lldb_codesign ================ Comment at: tools/debugserver/source/CMakeLists.txt:29 @@ +28,3 @@ + DNBThreadResumeActions.cpp + libdebugserver.cpp + PseudoTerminal.cpp ---------------- libdebugserver.cpp is not in the Xcode project. It seems like dead code. http://llvm-reviews.chandlerc.com/D1331 _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
