Re: [Lldb-commits] [PATCH] merge lldb-platform-work branch into trunk - implementation for additional platform packets in GDB server/client classes - updated docs for most new platform packets - stubs for new Platform:: functions - build the lldb-platform tool (with cmake) - pre-po

[Matt Kopec]

  I suggest fixing the printf format specifiers (ie. %lli) so that we don't get 
new build warnings.

  We should also run the test suite with this merged branch as tests have been 
updated.

  Also, check with Greg to see if he has any concerns/advice with this merge.


================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:139-143
@@ -136,3 +138,7 @@
 
+<<<<<<< .working
     @skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase 
support
+=======
+    @not_remote_testsuite_ready
+>>>>>>> .merge-right.r188820
     @skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
----------------
This needs to be resolved.

================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:191-195
@@ -184,3 +190,7 @@
 
+<<<<<<< .working
     @skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase 
support
+=======
+    @not_remote_testsuite_ready
+>>>>>>> .merge-right.r188820
     @skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
----------------
Same here

================
Comment at: test/functionalities/load_unload/TestLoadUnload.py:236-240
@@ -225,3 +235,7 @@
 
+<<<<<<< .working
     @skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase 
support
+=======
+    @not_remote_testsuite_ready
+>>>>>>> .merge-right.r188820
     @skipIfLinux # llvm.org/pr14424 - missing linux Makefiles/testcase support
----------------
Same here.

================
Comment at: tools/debugserver/debugserver.xcodeproj/project.pbxproj:609
@@ -608,3 +608,3 @@
                                "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "-";
-                               "CODE_SIGN_IDENTITY[sdk=macosx*]" = 
lldb_codesign;
+                               "CODE_SIGN_IDENTITY[sdk=macosx*]" = "";
                                COPY_PHASE_STRIP = YES;
----------------
This will probably cause issues on mac osx.


http://llvm-reviews.chandlerc.com/D1476
_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits