Also, concerning this additional MSVC include folder, I suppose it probably should end up somewhere else to not pollute distributed include folder. Probably in source/Host/msvc/include or something?
On Wed, Aug 28, 2013 at 10:53 PM, Virgile Bello <[email protected]>wrote: > Hello, > > Here is the tentative patch for MSVC12 support. Actually much smaller than > MinGW32 one (1/3). > Need some improvements/reviews. Some points that might need some > discussion: > > * getopt.h doesn't exist. Also, current inttypes.h doesn't work well > (should be fixed in final release so it will be removed later). > As a result, I added a folder include/msvc that can override some system > include. > I wanted to make sure it was OK to do so? If yes, is this folder OK or > somewhere else maybe? > Otherwise, I could always add lot of #ifdef around each <getopt.h> > include, but that might be ugly. > Note that MSVC11 might also need some more additional includes as well > (need to check). > > * Most of the other fixes are related to some subtle difference in > templates instantiation, as well as friend class within namespace that > needs forward declaration (cf CommandObjectBreakpointCommandAdd > and CommandObjectProcessLaunch).. > > * Also, I added backslash separator for paths in FileSpec.cpp (apply for > MinGW32 as well). > I might commit this separately if the MSVC patch takes some time to be > cleared out. > > * Only thing left to fix before it compiles is a MinGW32/MSVC compilation > error introduced yesterday by r189316 (otherwise it would probably have > been enough). > It's due to windows.h and llvm/Support/COFF.h conflicting #define/enum. I > hope to get this fixed in LLVM soon too. > > * I think the only thing I didn't include is a few printf("%zx") in > logging that needs to be fixed here and there (will be in a separate patch). > > Compilation OK on Linux. > > Thanks, > Virgile >
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
