This patch looks ok as long as you don't ever intend to do remote debugging from a non-windows system to a windows system.
I would vote to make it so that you can have the windows platform available from linux or MacOSX. This would mainly involve making sure the windows platform builds on non-windows systems and removing the "#if defined( _WIN32 )" and removing the Windows checks from the CMakeLists.txt files. Greg On Sep 27, 2013, at 9:22 AM, Deepak Panickal <[email protected]> wrote: > Hi, > > We would like to submit our first patch which will add PlatformWindows (based > on the PlatformWindows plugin from the previous Windows branch with minor > modifications). A Windows compatible command-line driver which we'll provide > another patch for today depends on the presence of PlatformWindows to > function properly. > > We have ran the test suite on Linux, and it passes succesfully. > In developing this patch for Windows, we used Visual Studio 2013 RC as the > compiler. > > The patch is based on trunk revision, > https://llvm.org/svn/llvm-project/lldb/trunk@191399 > > ( Additionally we also have successfully backported LLDB to build cleanly on > Visual Studio 2012. Would this support be of interest to anyone? ) > > Thanks, > Deepak Panickal > <PlatformWindows.patch>_______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
