Both look good to me. On Oct 14, 2013, at 3:22 AM, Deepak Panickal <[email protected]> wrote:
> Ping. Could you please confirm if the WindowsDriver > patch(http://llvm-reviews.chandlerc.com/D1785) and the PlatformWindows > patch(http://llvm-reviews.chandlerc.com/D1772) are now okay to be committed > to trunk? > I've obtained commit-after-approval access. > > Thanks, > Deepak > > On 10/10/13 15:45, Deepak Panickal wrote: >> Hi, >> >> I have updated the PlatformWindows patch with the changes that Greg and João >> suggested. I tried using clang-format for the patch but seems like LLDB >> style is not supported and the LLVM style looks quite different. >> >> We're still working on the Windows Driver patch. If the PlatformWindows >> patch looks okay, then could we commit it to trunk? Could you please advise >> on how to obtain commit access? >> >> Thanks, >> Deepak >> >> On 10/10/13 15:34, Deepak Panickal wrote: >>> Enable PlatformWIndows on other plaforms as Greg suggested >>> Fixed up spacing issues as per João. >>> >>> >>> http://llvm-reviews.chandlerc.com/D1772 >>> >>> >>> CHANGE SINCE LAST DIFF >>> >>> http://llvm-reviews.chandlerc.com/D1772?vs=4576&id=4806#toc >>> >>> >>> Files: >>> source/CMakeLists.txt >>> source/Plugins/Platform/CMakeLists.txt >>> source/Plugins/Platform/Windows/CMakeLists.txt >>> source/Plugins/Platform/Windows/PlatformWindows.cpp >>> source/Plugins/Platform/Windows/PlatformWindows.h >>> source/lldb.cpp >>> >>> >>> >>> _______________________________________________ >>> lldb-commits mailing list >>> >>> [email protected] >>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits >> > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
