In the handling of the "DW_OP_GNU_push_tls_address" case when evaluating the expression, you need to check the "thread" for NULL after you extract it from the "exe_ctx". You might get an execution context that only has a target specified.
Fix that and it all looks good to checkin. Greg On Oct 16, 2013, at 11:52 AM, Richard Mitton <[email protected]> wrote: > Per comments, fixed DWARF expressions to take an optional module, and moved > TLS handling from Process over into Thread. > > http://llvm-reviews.chandlerc.com/D1944 > > CHANGE SINCE LAST DIFF > http://llvm-reviews.chandlerc.com/D1944?vs=4936&id=4965#toc > > Files: > include/lldb/Target/Process.h > include/lldb/Target/Thread.h > source/Expression/DWARFExpression.cpp > source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp > source/Plugins/Process/POSIX/POSIXThread.cpp > source/Plugins/Process/POSIX/POSIXThread.h > source/Plugins/Process/POSIX/ProcessPOSIX.cpp > source/Plugins/Process/POSIX/ProcessPOSIX.h > source/Target/Process.cpp > source/Target/Thread.cpp > <D1944.2.patch>_______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
