Looks fine.
On Jan 27, 2014, at 9:50 AM, Todd Fiala <[email protected]> wrote:
> Proposed change:
>
> convert gdb-remote 'A' launch to use LaunchProcess ()
>
> This change modifies the 'A' command handler's launch code to launch with
> LaunchProcess (). The net effect is that the default process monitoring that
> LaunchProcess () adds will kick in, allowing the GDBRemoteCommunicationServer
> to be able to reap processes started with this facility correctly. Later, in
> the case of lldb-gdbserver, we'll also have the proper process monitoring
> going on to really debug the inferior process.
>
> Any issues with this? This code runs both in lldb-gdbserver and
> lldb-platform.
>
> ===================================================================
> --- source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
> (revision 200226)
> +++ source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
> (working copy)
> @@ -811,8 +811,11 @@
>
> if (success)
> {
> + // FIXME: remove linux restriction once eLaunchFlagDebug is supported
> +#if !defined (__linux__)
> m_process_launch_info.GetFlags().Set (eLaunchFlagDebug);
> - m_process_launch_error = Host::LaunchProcess (m_process_launch_info);
> +#endif
> + m_process_launch_error = LaunchProcess ();
> if (m_process_launch_info.GetProcessID() != LLDB_INVALID_PROCESS_ID)
> {
> return SendOKResponse ();
>
>
> --
> Todd Fiala | Software Engineer | [email protected] | 650-943-3180
>
> _______________________________________________
> lldb-commits mailing list
> [email protected]
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
