Here is an updated patch.

Le 3 févr. 2014 à 23:43, Jean-Daniel Dupas <[email protected]> a écrit :

> Thank you for the explanation. I missed that point when I read about 
> 'shared_from_this'.
> 
> Le 3 févr. 2014 à 20:49, Greg Clayton <[email protected]> a écrit :
> 
>> UnwindAssembly::FindPlugin() needs to be modified to return a 
>> UnwindAssemblySP and when each UnwindAssembly object is created you need to 
>> immediately put it into a shared pointer upon construction. When using 
>> enable_shared_from_this() you _must_ create the object by putting it into a 
>> shared pointer right away, otherwise when you use 
>> "unwinder.shared_from_this()" you will crash as the std::weak_ptr inside the 
>> enable_shared_from_this() class won't have been initialized correctly.
>> 
>> On Feb 2, 2014, at 6:00 AM, Jean-Daniel Dupas <[email protected]> wrote:
>> 

-- Jean-Daniel



Attachment: unwinder.patch
Description: Binary data

_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to