Done:

Sending        include/lldb/Utility/SharedCluster.h
Transmitting file data .
Committed revision 209010.

Thanks for doing this and to Todd for remembering to poke me about this!

Jim

On May 16, 2014, at 12:48 PM, Scott Knight <[email protected]> wrote:

> I do not have commit access so if someone who does could commit that would be 
> great.
> 
> Thanks,
> Scott Knight
> 
> On May 16, 2014 3:26 PM, <[email protected]> wrote:
> I got the same result.  This patch is much more likely to cause crashes than 
> failures if it was wrong, and I didn't see that either.  And the patch looks 
> reasonable.  I say check it in.
> 
> Jim
> 
> On May 16, 2014, at 12:23 PM, Scott Knight <[email protected]> wrote:
> 
> > I did go ahead and run dotest.py this morning both before and after 
> > applying the patch and it seems to have the same 10 failures before and 
> > after like you mentioned. Another set of eyes checking the test results 
> > would be great though.
> >
> > http://reviews.llvm.org/D3616
> >
> >
> >
> > _______________________________________________
> > lldb-commits mailing list
> > [email protected]
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
> 

_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to