Looks good. > On May 27, 2014, at 5:46 PM, Zachary Turner <[email protected]> wrote: > > Hi tfiala, > > As part of the contract of a dll-exported C++ interface, classes that are not > exported should not be accessible via a public interface of an exported > class, and doing so generates warnings on MSVC. These warnings can be safely > suprressed as long as all non-exported classes are part of the exported > class's private interface, so this change moves all such methods to the > private interface, friending where necessary, and finally suppresses the > warnings on MSVC. > > http://reviews.llvm.org/D3934 > > Files: > CMakeLists.txt > include/lldb/API/SBDebugger.h > include/lldb/API/SBFrame.h > include/lldb/API/SBProcess.h > include/lldb/API/SBQueueItem.h > include/lldb/API/SBTarget.h > include/lldb/API/SBThread.h > include/lldb/API/SBValue.h > include/lldb/API/SBWatchpoint.h > source/API/SBDebugger.cpp > <D3934.9856.patch>_______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
