On Tue, Jul 1, 2014 at 10:57 AM, Deepak Panickal <[email protected]> wrote: > > if (NOT MSVC) > set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") > endif() > - add_library(${name} ${libkind} ${srcs}) > + llvm_add_library(${name} ${libkind} ${srcs}) > #if (LLVM_COMMON_DEPENDS) > ##add_dependencies(${name} ${LLVM_COMMON_DEPENDS}) > #endif() > @@ -249,14 +257,7 @@ macro(add_lldb_library name) > endmacro(add_lldb_library) > > macro(add_lldb_executable name) > - #add_llvm_executable(${name} ${ARGN}) > - llvm_process_sources( ALL_FILES ${ARGN} ) > - add_executable(${name} ${ALL_FILES}) > - #target_link_libraries(${name} ${CLANG_USED_LIBS}) > - #llvm_config( ${name} ${LLVM_LINK_COMPONENTS} ) > - #if (LLVM_COMMON_DEPENDS) > - #add_dependencies(${name} ${LLVM_COMMON_DEPENDS}) > - #endif() > + add_llvm_executable(${name} ${ARGN}) > set_target_properties(${name} PROPERTIES FOLDER "lldb executables") > endmacro(add_lldb_executable) > > @@ -315,9 +316,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} > > #add_subdirectory(include) > add_subdirectory(docs) > -if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" AND NOT LLDB_DISABLE_PYTHON) > - add_subdirectory(scripts) > -endif() > +add_subdirectory(scripts) > add_subdirectory(source) > add_subdirectory(test) > add_subdirectory(tools) >
I think some of these changes broke building with CMake 3.0. This is what I get now when cmake reruns: $ ninja -C ../../build clang ninja: Entering directory `../../build' [1/1] Re-running CMake... FAILED: "C:\Program Files (x86)\CMake\bin\cmake.exe" -HD:\src\llvm -BD:\src\llvm\build -- Target triple: i686-pc-win32 ... snip -- LLDB version: 3.5.0 -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) CMake Error at tools/lldb/CMakeLists.txt:234 (target_link_libraries): The keyword signature for target_link_libraries has already been used with the target "liblldb". All uses of target_link_libraries with a target must be either all-keyword or all-plain. The uses of the keyword signature are here: * cmake/modules/AddLLVM.cmake:331 (target_link_libraries) Call Stack (most recent call first): tools/lldb/source/CMakeLists.txt:214 (add_lldb_library) -- Configuring incomplete, errors occurred! See also "D:/src/llvm/build/CMakeFiles/CMakeOutput.log". See also "D:/src/llvm/build/CMakeFiles/CMakeError.log". ninja: error: rebuilding 'build.ninja': subcommand failed So there's some conflict between llvm_add_library and target_link_libraries, which is unfortunate.
_______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
