Initially I was going to adjust the patch to pull out the PTRACE_* defines, but 
I'll leave them in for now based on this:

These things can be defined different ways for other architectures, e.g. for 
x86_64 Linux, asm/ptrace-abi.h defines them as preprocessor constants while 
sys/ptrace.h defines them in enum along with corresponding PT_* preprocessor 
constants

I'll have a deeper look at this after I get it running on a cross compiler and 
x86/x86_64/ARM/ARM64.  We may want to go ahead and just define these using 
known-to-be-correct values for the target but define them ourselves with 
non-colliding LLDB constants (for example, see the UnixSignals* hierarchy, 
which defines the values directly rather than pulling in system header values 
that are only correct for the compiler host or cross-compiler headers).

http://reviews.llvm.org/D4366



_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to