On 10 July 2014 21:48, Todd Fiala <[email protected]> wrote: > > Matthew, > > Your patch looks good to me. I would like Greg and/or Ed to have a look at it > too. If they don’t object, I can submit it. > > I ran tests on Linux and MacOSX with the patch applied
The change LGTM and it passes on FreeBSD. One little point to keep in mind is that there are ELF files that have no section headers. We should avoid (further) conflating m_section_headers.empty() with having not yet parsed the header. _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
