Re: [Lldb-commits] [PATCH] ObjectFileMachO: Silence signed/unsigned comparison warning

[David Majnemer]

Closed by commit rL213822 (authored by @majnemer).

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D4634

Files:
  lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Index: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -5426,8 +5426,7 @@
                             // Now write the file data for all memory segments 
in the process
                             for (const auto &segment : segment_load_commands)
                             {
-                                off_t offset = 
core_file.SeekFromStart(segment.fileoff);
-                                if (offset < 0 || segment.fileoff != 
static_cast<uint64_t>(offset))
+                                if (core_file.SeekFromStart(segment.fileoff) 
== -1)
                                 {
                                     error.SetErrorStringWithFormat("unable to 
seek to offset 0x%" PRIx64 " in '%s'", segment.fileoff, core_file_path.c_str());
                                     break;

Index: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -5426,8 +5426,7 @@
                             // Now write the file data for all memory segments in the process
                             for (const auto &segment : segment_load_commands)
                             {
-                                off_t offset = core_file.SeekFromStart(segment.fileoff);
-                                if (offset < 0 || segment.fileoff != static_cast<uint64_t>(offset))
+                                if (core_file.SeekFromStart(segment.fileoff) == -1)
                                 {
                                     error.SetErrorStringWithFormat("unable to seek to offset 0x%" PRIx64 " in '%s'", segment.fileoff, core_file_path.c_str());
                                     break;

_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits