[Lldb-commits] [PATCH] Handle unexpected output in test output

[Ed Maste]

Hi gkistanova,

LitTestCommand has a set of descriptions for test result codes, and ends up 
throwing an exception if an unexpected result is somehow reported.

For example, see the FreeBSD buildbot:
http://lab.llvm.org:8011/builders/lldb-x86_64-freebsd/builds/77/steps/test%20lldb/logs/err.html

We've been running the patch in this review on the FreeBSD-specific buildbot:
http://llvm-amd64.freebsd.your.org/b/builders/lldb-amd64-freebsd

http://reviews.llvm.org/D4775

Files:
  zorg/buildbot/commands/LitTestCommand.py

Index: zorg/buildbot/commands/LitTestCommand.py
===================================================================
--- zorg/buildbot/commands/LitTestCommand.py
+++ zorg/buildbot/commands/LitTestCommand.py
@@ -140,7 +140,10 @@
   def describe(self, done=False):
     description = Test.describe(self, done)
     for name, count in self.logObserver.resultCounts.iteritems():
-        description.append('{0} {1}'.format(count, self.resultNames[name]))
+        if name in self.resultNames:
+            description.append('{0} {1}'.format(count, self.resultNames[name]))
+        else
+            description.append('Unexpected test result output ' + name)
     return description
 
 ##

Index: zorg/buildbot/commands/LitTestCommand.py
===================================================================
--- zorg/buildbot/commands/LitTestCommand.py
+++ zorg/buildbot/commands/LitTestCommand.py
@@ -140,7 +140,10 @@
   def describe(self, done=False):
     description = Test.describe(self, done)
     for name, count in self.logObserver.resultCounts.iteritems():
-        description.append('{0} {1}'.format(count, self.resultNames[name]))
+        if name in self.resultNames:
+            description.append('{0} {1}'.format(count, self.resultNames[name]))
+        else
+            description.append('Unexpected test result output ' + name)
     return description
 
 ##

_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits